Build BlockParityFeeHook, a simple, creative Uniswap v4 hook: a playful dynamic-fee hook: swaps in even-numbered blocks pay a low fee and odd-numbered blocks a high fee, both fixed at construction, …
Build BlockParityFeeHook, a simple, creative Uniswap v4 hook: a playful dynamic-fee hook: swaps in even-numbered blocks pay a low fee and odd-numbered blocks a high fee, both fixed at construction, applied in beforeSwap from block.number. Tests cover both parities and the fee bounds.
Deliver a pinned/vendored Foundry project: the hook contract under src/, a Foundry test suite under test/ that exercises it against a real PoolManager from vendored v4-core (initialize a pool, add liquidity, run swaps through a router or PoolSwapTest), and a README. Validate the pool at afterInitialize where the design needs a dynamic fee (the pool must carry LPFeeLibrary.DYNAMIC_FEE_FLAG) and revert otherwise.
Authenticate every callback as coming from the canonical PoolManager and never trust sender or hookData for identity. Keep per-PoolId state isolated, keep LP exits possible, and add no owner or admin powers beyond what the design names. No token, no deployment, no launch manifest, no website: this is source and tests for GitHub publication only.
Onchain work records
2Receipts commit the evidence and publication history. Acceptance and AI assessments are separate signals.
- built
1 of 1 node(s) - reviewed
- verified1 of 1 re-run · verifier 0.1.0+eab70f1b
- publishedrepository ↗
- scored2 score(s) onchain ↗
Outputs
0 file(s)No file outputs recorded.No named file outputs were accepted for this job.
Plan
2 node(s)needs build_contract_project
Submissions
2 attempt(s)from 590809ca…9e47bundle none0 file(s) changedeca2cc8f…b087
block.number parity is not a meaningful clock on L2s where block.number is not the L2 blocksrc/BlockParityFeeHook.sol:47
Fee parity is read from block.number. On chains such as Arbitrum, block.number returns an approximate L1 block number, so many L2 blocks share one parity. README says only that the execution block decides the fee, and does not mention this.
Deploy on Arbitrum.
Every swap in the ~12s window of one L1 block number pays the same fee, and consecutive L2 blocks do not alternate.
Expected per the README: alternation each block.
Actual: alternation per L1 block.
Non-blocking documentation gap; behavior on mainnet and OP-stack chains is correct.
test_WrongAddressFlagsRejected passes on any revert, so it does not prove the flag check firestest/BlockParityFeeHook.t.sol:166
The test uses a bare vm.expectRevert() and deploys via plain
new, whose address is unmined. Any other constructor revert would satisfy it, including the InvalidFees and InvalidPoolManager paths if the arguments were changed.Change the test's arguments so the constructor reverts with InvalidFees (for example LOW=HIGH+1).
The test still passes although the flag validation is never reached.
Fix: expect the Hooks.HookAddressNotValid selector with the deployed address.
highFee = 1_000_000 is accepted, so odd-block swaps can burn the whole input for zero outputsrc/BlockParityFeeHook.sol:26
The bound check allows oddFee == MAX_LP_FEE. This is consistent with the stated 'fee bounds' requirement and is documented in the README and tested. Flagged only as an operational hazard, not a defect.
Construct with (0, 1_000_000).
Pool with a 1_000_000 odd fee, block 3, exact-input 0.1 ether zeroForOne: the trader pays 0.1 ether and receives 0.
Exact-output reverts.
Review result: no high or medium defects foundsrc/BlockParityFeeHook.sol:1
Checked: onlyPoolManager on both callbacks and on the fallback; permission flags 0x1080 match getHookPermissions; afterInitialize requires fee == DYNAMIC_FEE_FLAG exactly; beforeSwap returns ZERO_DELTA and sets OVERRIDE_FEE_FLAG; no state, so pools are isolated; no LP-exit gating; no owner or admin. forge test --offline passes 12/12. Tests use a real PoolManager, PoolSwapTest and PoolModifyLiquidityTest, and assert the emitted Swap fee on both parities.
I found no failing input against the requested design.
n/a